I ran the opac advanced search page through https://validator.w3.org/ It gave a fatal error on the closing </form> tag following </div> <!-- / .main --> due to a missing </div> tag which should match <div class="container-fluid">. This is happening in master, and goes back at least as far as 3.18. It doesn't affect the rendering of the page, as far as I can tell.
Created attachment 62608 [details] [review] Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable.
Created attachment 62650 [details] [review] Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>
Created attachment 62748 [details] [review] Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Owen!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Pushed to 3.22.x for 3.22.21
Pushed to 16.05.x, for 16.05.13 release