The opac-search-history script is missing the standard `authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),` line and therefore does not repsect the OpacPublic preference.
Created attachment 62809 [details] [review] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page.
Good catch!
Created attachment 62919 [details] [review] [SIGNED OFF]] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer@web.de>
Created attachment 62923 [details] [review] [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Fixed my sign-off line. Martin, do you want to fix authorship too? From: PTFS Admin <hosting@ptfs-europe.com>
Oh, good catch on the Authorship line.. I must have done the original work on a different server to normal.
Created attachment 62925 [details] [review] [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Only noticed because of my own mistake (typo in my git alias) :)
Created attachment 62945 [details] [review] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Martin!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Pushed to 3.22.x for 3.22.21
Pushed to 16.05.x, for 16.05.13 release