When I try to create an order line from an accepted suggestion, I get an error: Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Can someone confirm?
The problem appears, when item-level_itypes = biblio.
Created attachment 62997 [details] [review] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone
Created attachment 62998 [details] [review] [SIGNED OFF] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 63327 [details] [review] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Jonathan!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Pushed to 16.05.x, for 16.05.13 release