The form to create or edit a card template has a confusing sequence of fields for page and card height and width: Page width - Page height - Card height - Card width Switch Card height and Card width to make it more intuitive.
Created attachment 63014 [details] Confusing fields for height and width
Created attachment 63017 [details] [review] Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width
Created attachment 63262 [details] [review] Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Still applies on current master
Created attachment 67664 [details] [review] Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!