The pickup location pulldown is populated with only the users branch when IndependentBranches is enabled - if the actual pickup location is a different library you instead see the current library To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian
Created attachment 63043 [details] [review] Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown
Created attachment 63260 [details] [review] Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
QA: Looking here now
Created attachment 63572 [details] [review] Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Nick!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Blocked by Enhancement, skipping for 16.05.x