In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code.
Created attachment 63171 [details] [review] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message
Ah maybe depends on 18518
*** Bug 18518 has been marked as a duplicate of this bug. ***
I tested but did not yet sign off because this bug is marked as 'In discussion' With this patch, two of the reasons are gone (yellow dialogue and data table). I think there is one more thing to be addressed: The form for the search filters shortly displays and then hides again. It moves the whole page down and up again. Do you have an idea how to fix it?
This is happening all over, and I think possibly it's more to do with when the JS is loading. Maybe instead of document.ready, we need document.onload?
(In reply to Liz Rea from comment #5) > This is happening all over, and I think possibly it's more to do with when > the JS is loading. > > Maybe instead of document.ready, we need document.onload? Ah, I dont know that. I think we should has this on koha-dev. But I think this patch will always be usefull because it converts existing hide() JS call into CSS, which is more performant.
Created attachment 63287 [details] [review] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4
Created attachment 63314 [details] [review] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 63315 [details] [review] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc Véron <veron@veron.ch>
Two issues are addressed with first two patches, I signed the patches off. But there is one more problem showing up (It was hidden by the first two problems): To reproduce: - Apply first two patches - Go to Home > Patrons - Have a close look to the tabs Search Patrons / Check out / Check in ... - You will see that first there is no green line around the tabs and the first tab 'Search patrons' is not in bold. The height of the whole search part changes, moving the rest of the page contents up. Then the green line appears, font of 'Search patron' changes to bold, the area of the search part expands and the rest of the page moves down again. - You can reproduce by performing a search as well
Hi Marc, Can you specify the browser you are using and its version, because I can't reproduce the problem.
(In reply to Philippe Audet-Fortin from comment #11) > Hi Marc, > > Can you specify the browser you are using and its version, because I can't > reproduce the problem. Firefox 53.0 (Windows) Firefox ESR 45.3.0 (Debian) See following comment as well (slow down with toogle(500): https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518#c5
Looks nice to me. It happens very fast on a good computer so it is not easy to reproduce. Use an old Pentium II ;)
Created attachment 63489 [details] [review] [SIGNED-OFF] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com>
Created attachment 63490 [details] [review] [SIGNED-OFF] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com>
Created attachment 63491 [details] [review] [SIGNED-OFF] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com>
Created attachment 63492 [details] [review] [SIGNED-OFF] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com>
Created attachment 63546 [details] [review] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 63547 [details] [review] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Frido, Josef!
These patches have been pushed to 16.11.x and will be in 16.11.08.
Pushed to 16.05.x, for 16.05.13 release
After talking to Owen about a possible solution, I am reverting these patches from 16.11.x, as they cause a display problem with the floating toolbar for patrons (see bug 18685). Mason, you might want to check if you want to revert as well!
As we have a bug fix now for the problem with the floating toolbar (bug 18685) I'd give this another go for 16.11.x, but patches don't apply cleanly. Please check!
Please rebase for 16.11.x if you want to see this and the bugs its blocking included in 16.11.x!
Created attachment 65452 [details] [review] Bug 18551: [16.11.x] followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Philippe <philippe.audet-fortin@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Katrin Fischer from comment #25) > Please rebase for 16.11.x if you want to see this and the bugs its blocking > included in 16.11.x! Patch does not apply simply because lines are added at the end of staff-global.css and since last lines are not the same in master the patch is lost ;)
(In reply to Fridolin SOMERS from comment #27) > (In reply to Katrin Fischer from comment #25) > > Please rebase for 16.11.x if you want to see this and the bugs its blocking > > included in 16.11.x! > > Patch does not apply simply because lines are added at the end of > staff-global.css and since last lines are not the same in master the patch > is lost ;) Note that you must clear cache after applying the patch (Ctrl+F5). Tested on Firefox 54.
Thx Fridolin for providing the patch! This patch has been pushed to 16.11.x and will be in 16.11.11.
Pushed to 16.05.x, for 16.05.16 release
(In reply to Katrin Fischer from comment #29) > Thx Fridolin for providing the patch! > > This patch has been pushed to 16.11.x and will be in 16.11.11. hi Cait i think 16.11.11 is missing this patch.. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546 ..currently patron search seems broken
Mason, you were right. Thx a lot for catching this! Missing patch has been pushed to 16.11.x and will be in 16.11.12.
(In reply to Katrin Fischer from comment #32) > Mason, you were right. Thx a lot for catching this! > > Missing patch has been pushed to 16.11.x and will be in 16.11.12. Pushed to 16.05.17 release too