Created attachment 63264 [details] [review] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools
Created attachment 63266 [details] [review] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 63286 [details] [review] [SIGNED-OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Sure this doesn't need a signoff, but I was already signing off when Marc did!
Mark, You are not allowed to call _result outside of Koha::* Actually you do not need to retrieve the author and the title, they are both returned by GetBiblioData few lines above. And actually I do not understand this "if rss" conditional block, it looks useless.
Created attachment 63340 [details] [review] Bug 18560: RSS link in opac shelves is broken Removed pointless code. TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools
(In reply to Jonathan Druart from comment #4) > You are not allowed to call _result outside of Koha::* Sorry, was just looking for a quick fix. > Actually you do not need to retrieve the author and the title, they are both > returned by GetBiblioData few lines above. Confirmed. > And actually I do not understand this "if rss" conditional block, it looks > useless. Patch revised accordingly.
We are a bit sparse with information in the RSS feed, for example if the entry is an article record, you would like to show the source as well. But this definitely fixes a bug.
Created attachment 63375 [details] [review] [SIGNED OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 63381 [details] [review] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Simple patch, fixes the bug as expected
(In reply to Katrin Fischer from comment #7) > We are a bit sparse with information in the RSS feed, for example if the > entry is an article record, you would like to show the source as well. But > this definitely fixes a bug. Actually, that's the other thing I did notice. RSS feeds are not consistent in what they output. This one needs improvement, but that is beyond the scope of this specific bug.
Pushed to master for 17.05, thanks Mark!
This patch has been pushed to 16.11.x and will be in 16.11.08.