In the suggestion detailed view, every field is displayed even if it is empty. This view should hide rows which contain no data.
Created attachment 63391 [details] [review] Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying.
Created attachment 63422 [details] [review] [SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 64419 [details] [review] Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x