This bug report is opened for didactic purpose. If you already contributed to Koha you must not contribute here.
Created attachment 64236 [details] [review] Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed
Created attachment 64237 [details] [review] Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed
Created attachment 64238 [details] [review] Bug 18584: Fix trailing spaces in C4/Accounts.pm Removed trailing spaces at line 182 of C4::Accounts. Test plan: 1. Edit C4/Accounts.pm and verify trailing spaces 2. Apply patch 3. Verify that trailing spaces in C4/Accounts have been removed Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
(In reply to Lee Jamison from comment #3) > Created attachment 64238 [details] [review] [review] > Bug 18584: Fix trailing spaces in C4/Accounts.pm Pushed to master, thanks Lee! Resetting to New.
... and pushed to 2 stable releases (16.11 and 17.05) - congrats Lee!
Pushed to 16.05.x, for 16.05.15 release
Created attachment 67095 [details] [review] Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279.
Created attachment 67096 [details] [review] Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Created attachment 67097 [details] [review] Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Dominic Pichette from comment #7) > Created attachment 67095 [details] [review] [review] > Bug 18584 - removed white space in C4/Accounts.pm > > Test Plan: > 1-go to C4/Accounts.pm > 2-there should not be a trailing space at line 279. Pushed to master, Merci Dominic! Resetting to New.
Created attachment 67157 [details] [review] Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67158 [details] [review] Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67159 [details] [review] Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67160 [details] [review] Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67161 [details] [review] Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Sorry, I attached to the wrong bug...
5400795 Bug 18584 - removed white space in C4/Accounts.pm Pushed to 17.05.x
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release
Walking through the Koha-how-to
Created attachment 79734 [details] [review] Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25
Created attachment 79743 [details] [review] Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25
Okay, I won't submit anything, as per comment #0, but I thought I would mention that "git stripspace" might be a useful command to read up on. That being said, C4/Matcher.pm has more to be found. However, to not take away a sense of accomplishment, I will sign off Cori's patch. :)
Created attachment 79758 [details] [review] Bug 18584: - removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This bug here is for learning, not about solving it all :)
(In reply to Cori Lynn Arnold` from comment #22) > Created attachment 79743 [details] [review] [review] Hi Cori, thanks for your patch. If you had followed the tutorial until the end you should have sent a signed off patch by yourself. I am going to mark this one as Passed QA as it has been signed off by Mark, but do not hesitate to give another go with a new patch ;)
Created attachment 79811 [details] [review] Bug 18584: Removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 79953 [details] [review] Bug 18584: Removed white space in C4/Matcher.pm Test Plan: 1-go to C4/Matcher.pm 2-verify there is no whitespace at line 25 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com>
Awesome work all! Great job on your first patch Cori! Pushed to master for 18.11
Resetting to New.
Created attachment 81990 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 82337 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Welcome aboard Thatcher, Signed Off.
Created attachment 82347 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Well done! Welcome to the Koha developers!
Awesome work all! Great job on your first patch Thatcher! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.13
Created attachment 85966 [details] [review] Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off.
Created attachment 85967 [details] [review] Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 85968 [details] [review] Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 19.05
Created attachment 87746 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87750 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Awesome work Thatcher, welcome aboard :)
Created attachment 87775 [details] [review] Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces and replaces tab characters with spaces in the branch transfer limits template. Mentored-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Resetting :)
Created attachment 175456 [details] [review] Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces
Created attachment 175458 [details] [review] Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175610 [details] [review] Bug 18584: Fix trailing spaces in C4/Acquisition.pm Test plan: this patch removes trailing spaces from Acquisiton.pm Run the QA script and confirm there are no trailing spaces Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Welcome, Annisha! :)
Welcome Annisha! To make sure you show up in the committers list as you'd like: At the moment your author line just has your first name. Would you like me to add your last name as well? (Failed QA here just means: I got a question!)
(In reply to Katrin Fischer from comment #55) > Welcome Annisha! > > To make sure you show up in the committers list as you'd like: > At the moment your author line just has your first name. Would you like me > to add your last name as well? > > (Failed QA here just means: I got a question!)
(In reply to Katrin Fischer from comment #56) > (In reply to Katrin Fischer from comment #55) > > Welcome Annisha! > > > > To make sure you show up in the committers list as you'd like: > > At the moment your author line just has your first name. Would you like me > > to add your last name as well? > > > > (Failed QA here just means: I got a question!) Thanks Katrin! I should have double checked the standard that others use when I was working through this. I am happy to go with my full name, Annisha Romney (I just updated it in my account preferences here as well.) Thanks!
(In reply to Annisha Romney from comment #57) > (In reply to Katrin Fischer from comment #56) > > (In reply to Katrin Fischer from comment #55) > > > Welcome Annisha! > > > > > > To make sure you show up in the committers list as you'd like: > > > At the moment your author line just has your first name. Would you like me > > > to add your last name as well? > > > > > > (Failed QA here just means: I got a question!) > > Thanks Katrin! I should have double checked the standard that others use > when I was working through this. I am happy to go with my full name, Annisha > Romney (I just updated it in my account preferences here as well.) > > Thanks! It's all good :) I'll update your author line accordingly before push. Thanks!
Pushed for 25.05! Well done everyone, thank you!