Bug 1859 - Notice fields: can't select multiple fields at once
Summary: Notice fields: can't select multiple fields at once
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-20 03:12 UTC by Chris Cormack
Modified: 2016-12-05 21:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 1859 - Notice fields: can't select multiple fields at once (5.08 KB, patch)
2016-05-13 12:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 1859 - Notice fields: can't select multiple fields at once (5.10 KB, patch)
2016-05-13 12:47 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 1859 - Notice fields: can't select multiple fields at once (5.17 KB, patch)
2016-05-13 21:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 1859: Do not display <<>> if an entry without value is selected (1.27 KB, patch)
2016-05-13 21:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:35:27 UTC


---- Reported by tina.burger@liblime.com 2008-02-20 15:12:21 ----

can't select multiple fields at once using the usual 'shift' for example.



---- Additional Comments From nengard@gmail.com 2009-12-23 17:58:49 ----

This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:35 UTC  ---

This bug was previously known as _bug_ 1859 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1859

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was tina.burger@liblime.com.

Comment 1 Owen Leonard 2016-05-13 00:27:25 UTC
If you're building a notice and select multiple fields, either by using click+shift+click or ctrl+click, when you add them they are not added as separate fields:

<<branches.branchname, branches.branchaddress2, branches.branchzip>>

Instead of <<branches.branchname>><<branches.branchaddress2>><<branches.branchzip>>
Comment 2 Owen Leonard 2016-05-13 12:40:50 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-05-13 12:47:57 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-05-13 21:05:00 UTC
Created attachment 51489 [details] [review]
Bug 1859 - Notice fields: can't select multiple fields at once

When selecting database fields to appear in a notice, selecting multiple
fields at once doesn't work correctly. The selected fields are grouped
together between << and >> instead of each being bracketed separately.

This patch corrects this problem. Also changed: Removal of 'onclick';
Conversion of 'insert' button to a Bootstrap buttons styled with a Font
Awesome icon; HTML validation error fixes.

To test, apply the patch and go to Tools -> Notices & Slips.

- Edit any notice.
- Select a notice version to edit (Email, Print, etc.).
- Confirm that the "Insert" button looks correct.
- Using ctrl+click, select multiple database fields to add to the
  notice. Confirm that clicking the "Insert" button adds the fields
  correctly.
- Confirm that there are no HTML validation errors.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2016-05-13 21:05:04 UTC
Created attachment 51490 [details] [review]
Bug 1859: Do not display <<>> if an entry without value is selected

For instance there are ---TABLES--- to delimite fields' tables, if
selected we do not want to add "<<>>" to the letter.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Kyle M Hall 2016-05-16 17:27:07 UTC
Pushed to master for Koha 16.05, thanks Owen, Jonathan!
Comment 7 Julian Maurice 2016-05-17 05:47:59 UTC
Patch pushed to 3.22.x, will be in 3.22.7