When we place an order from a suggestion, a biblio record is created and its number is stocked in suggestion table. If we merge this biblio record with another one (and prefering the other one), the biblio number is changed in the order but not in the suggestion, so we lost the link between this order and the suggestion. ANd the patron will not be alerted when the document will be received.
Would be good to see this fixed! As a suggestion always creates a new record the merge operation is often used.
Could you detail? It seems to work for me.
Tested on master: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated)
Created attachment 70233 [details] [review] Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record
Patch tested with a sandbox, by Lucie Gay <lucie.gay@ens-paris-saclay.fr>
Created attachment 72690 [details] [review] Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr>
It's ok : the new title displays in the acquisition record after merging, but not in suggestions. However the information "Available in library" displays in suggestions.
QA: Looking here now
Created attachment 73159 [details] [review] Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, backported to stable for 17.11.05
Pushed to 17.05.x for 17.05.11