To recreate 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Swithc to quick add, view values, save 6 - Values are not saved :-(
Created attachment 63443 [details] [review] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-)
Created attachment 63448 [details] [review] [SIGNED-OFF] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov>
*** Bug 18612 has been marked as a duplicate of this bug. ***
I do not manage to see the patron attributes on the quick add form.
(In reply to Jonathan Druart from comment #4) > I do not manage to see the patron attributes on the quick add form. Ha, we have to guess the id of the attribute in DB. That's very badly implemented.
Created attachment 63543 [details] [review] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Nick!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Blocked by new feature, skipping for 16.05.x