Calling Guided reports wizard from Home > Reports results in an Internal Server Error. Plack error log says: Could not compile /home/marc/koha/reports/guided_reports.pl: Can't locate Data/Printer.pm in @INC It seems that the module Data::Printer is missing, but About page and installation tool do not complain about.
Introduced by first patch in Bug 17898 - Add a way to automatically convert SQL reports
Created attachment 63607 [details] [review] Bug 18642: Add missing dependency for Data::Printer module Test plan: 1) Go to About page -- without patch you can't see Data::Printer listed -- with patch you'll see it 2) uninstall Data::Printer - apt-get remove libdata-printer-perl 3) go to Reports -> Use saved - you'll see ISE 4) install the module again - apt-get install libdata-printer-perl 5) go to Reports -> Use saved - everything should work fine
When rebasing the original patches, I introduced the dep for debugging purposes only. We should just remove the code that uses Data::Printer instead!
Created attachment 63609 [details] [review] Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine
(In reply to Tomás Cohen Arazi from comment #3) > When rebasing the original patches, I introduced the dep for debugging > purposes only. We should just remove the code that uses Data::Printer > instead! Ok, I've attached new patch. Thanks!
Created attachment 63612 [details] [review] Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 63615 [details] [review] Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Josef!
Depends on bug 17898 which is not part of 16.11.x.