Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %]
Created attachment 63639 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before
Created attachment 63772 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 63931 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I am not sure this patch is correct, and a chat with cait did not satisfy my feeling See the following for fr-FR (I searched for 'scriptname') Before bug 18652: 10158 #. META http-equiv=Refresh 10159 #: intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt:41 10160 msgid "0; url=[% scriptname %]?booksellerid=[% booksellerid %]" 10161 msgstr "0; url=[% scriptname %]?booksellerid=[% booksellerid %]" After bug 18652 and translate update: 1090 #. %1$s: INCLUDE 'acquisitions-toolbar.inc'. 1091 #. %2$s: IF ( validate ). 1092 #. %3$s: BLOCK metacontent. 1093 #. %4$s: scriptname. 1094 #. %5$s: booksellerid. 1095 #. %6$s: END. 1096 #: intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt:37 1097 #, fuzzy, c-format 1098 msgid "%s %s %s0; url=%s?booksellerid=%s%s " 1099 msgstr "%s %s %s %s (fermé) %s " That looks worst.
Created attachment 64141 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended to switch from BLOCK to a template variable, see comment #5 Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po
Not sure where to set status now - setting it to SO Please set it to NSO if an other Sign off is needed.
The patch has been rewritten, Signed-off-by lines should not be kept.
Created attachment 64151 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5
Still applies on current master
Created attachment 65399 [details] [review] [SIGNED-OFF] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 66641 [details] [review] Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.04. Nice work
This patch has been pushed to 16.11.x and will be in 16.11.12.
Pushed to 16.05.x, for 16.05.17 release