Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s
Created attachment 63643 [details] [review] Bug 18654: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s This patch fixes it. To test: - Apply patch - Verify that itemsearch behaves as before - Verify that code changes make sense - Test a translatiion e.g. translator create aa-AA and verifiy that strings from itemsearch.tt starting with [%% no longer appear
Created attachment 63773 [details] [review] Bug 18654: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s This patch fixes it. To test: - Apply patch - Verify that itemsearch behaves as before - Verify that code changes make sense - Test a translatiion e.g. translator create aa-AA and verifiy that strings from itemsearch.tt starting with [%% no longer appear Followed test plan and patch worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
+[% BLOCK fieldset_start %]<fieldset>[% END %] +[% BLOCK fieldset_end %]</fieldset>[% END %] This is not acceptable, why do you need that?
(In reply to Jonathan Druart from comment #3) > +[% BLOCK fieldset_start %]<fieldset>[% END %] > +[% BLOCK fieldset_end %]</fieldset>[% END %] > > This is not acceptable, why do you need that? You are right, it is not necessary to replace the fieldset tags.
Created attachment 64177 [details] [review] Bug 18654: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s This patch fixes it. To test: - Apply patch - Verify that itemsearch behaves as before - Verify that code changes make sense - Test a translatiion e.g. from folder misc/translator: perl translate create aa-AA ...and verifiy that strings translated from itemsearch.tt and starting with [%% no longer appear in aa-AA-staff-prog.po (Patch re-written, needs a new sign-off)
Created attachment 64723 [details] [review] Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before
Still applies
Created attachment 65407 [details] [review] Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 66640 [details] [review] Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Ah there is a typo in patch : [% INCLUDE form_field_select name="holdingbranch" options = branche Its branche[s]. I create a follow-up patch
Created attachment 67082 [details] [review] Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt - followup Followup correcting a typo of previous patch : name="holdingbranch" options = branche it is branche[s] Test plan : - Look at 'Current location' in item search => Without patch you see only 'All libraries' => With patch you see 'All libraries' and each existing library, like in 'Home library'
(In reply to Fridolin SOMERS from comment #12) > Created attachment 67082 [details] [review] [review] > Bug 18654 - Translatability: Get rid of tt directives starting with [%% in > translation for itemsearch.tt - followup Last patch pushed to master, thanks Frido!
Pushed to 17.05.x, will be in 17.05.04.
These patches have been pushed to 16.11.x and will be in 16.11.12.
Pushed to 16.05.x, for 16.05.17 release