"Replace only included patron attributes" on the patron import page is the less dangerous option and should be the default. If you forget to switch from "Replace all patron attributes" any additional attributes will be silently deleted.
Created attachment 70572 [details] [review] Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default.
Problem on sandbox 8. Not tested. The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18661: <h1>Something went wrong !</h1>Applying: Made Replace only included patron attributes default on patron import Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt error: Failed to merge in the changes. Patch failed at 0001 Made Replace only included patron attributes default on patron import The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 18661 - Make Replace only included patron attributes default on patron import 70572 - Made Replace only included patron attributes default on patron import Apply? [(y)es, (n)o, (i)nteractive] Patch left in tmpMade-Replace-only-included-patron-attributes-defau-C0CswV.patch .
Created attachment 84031 [details] [review] Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default.
Hi Jasmine. The patch works, but it duplicates the patron attributes form section and puts it AFTER the Notes section on the right hand side(depending on your browser window size). It should update the form section before the import button, which starts at around line 223. David
Created attachment 84085 [details] [review] Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default.
Created attachment 84087 [details] [review] Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. Signed-off-by: David Nind <david@davidnind.com>
Thanks Jasmine!
Created attachment 84088 [details] [review] Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx, Jasmine! I'd be nice if you could add a little note to the "Text to go in the release notes" describing the change in behaviour.
Thx, Jasmine!
Awesome work all! Pushed to master for 19.05
A good enhancement, but it brings a change of functionality which could prove surprising to end users on the stable branch.. as such I will not be backporting this one to 18.11.x series.