We have a few commented out RewriteLog and RewriteLogLevel directives in various Apache configuration files and templates. These directives aren't used in Apache 2.4. They've been replaced with the LogLevel directive. Since they're commented out, I don't think it matters too much for production systems, but it could lead to confusion if people tried uncommenting them and they don't work (yep that was me). We could wrap the two different styles in IfVersion directives to make things easier for people.
The lines still appear: debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-opac-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1 etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-intranet-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1
I'll attach a patch removing the commented lines to get this moving, but others might be able to tell better than me if this is a good idea or not :)
Created attachment 103212 [details] [review] Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it
Created attachment 103224 [details] [review] Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind <david@davidnind.com>
Created attachment 104279 [details] [review] Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11