Bug 18671 - Calendar.t failing exception holiday test
Summary: Calendar.t failing exception holiday test
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-25 18:56 UTC by Katrin Fischer
Modified: 2020-11-30 21:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-05-25 18:56:06 UTC 
Test is failing on master - I haven't verified yet if that points to a real problem, so just setting to 'normal' for now.

prove t/Calendar.t 
t/Calendar.t .. 1/38 
#   Failed test 'Exception holiday is not a closed day test'
#   at t/Calendar.t line 164.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 38.
t/Calendar.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/38 subtests
Comment 1 Marc Véron 2017-05-29 06:04:05 UTC 
It depends on syspref 'CalendarFirstDayOfWeek'

prove -v t/Calendar.t

If CalendarFirstDayOfWeek is set to Sunday, test passes OK
If CalendarFirstDayOfWeekset is set to Monday, test fails with:

not ok 13 - Exception holiday is not a closed day test
#   Failed test 'Exception holiday is not a closed day test'
#   at t/Calendar.t line 164.
#          got: '1'
#     expected: '0'
Comment 2 Katrin Fischer 2020-04-19 11:45:58 UTC 
Tests pass with the right standard config, so marking as WONTFIX.