There are some typos in the SchemaSpy description of table "borrowers". * http://schema.koha-community.org/16_11/tables/borrowers.html 1. In the comment for field "debarred" (YYY-MM-DD) should by replaced by (YYYY-MM-DD) 2. In the comment for field "smsalertnumber" SNS should be replaced by SMS 3. In the comments of fields "contactname", "contacttitle", "guarantorid", "relationship" the term "guarentor" is used, but it should be "guarantor". 4. The comment for field "password" reads "patron/borrower's encrypted password". I think it could be more explicit by writing "patron/borrower's Bcrypt encrypted password".
Verified for current master.
Created attachment 63833 [details] [review] Bug 18690 - Typos in Koha database description (Table "borrowers") This string patch fixes typos in kohastructure.sql as described in initial comment. To test: - Carefully verify that string changes make sense
Strings are now correct as expected.
Thanks, Michael, for testing and confirming that changes are OK. But sorry, to set a bug to Signed Off you have to apply the patch on your development environment, then sign off on the patch (that adds your sign off to the patch), and then attach the patch again. See https://wiki.koha-community.org/wiki/Sign_off_on_patches I use the git bz workflow mentioned there, see: https://wiki.koha-community.org/wiki/Git_bz_configuration Setting back to NSO
Created attachment 63997 [details] [review] Bug 18690 - Typos in Koha database description (Table "borrowers") This string patch fixes typos in kohastructure.sql as described in initial comment. To test: - Carefully verify that string changes make sense Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09.
Pushed to 16.05.x, for 16.05.15 release