In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next().
Created attachment 63864 [details] [review] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted
Created attachment 63865 [details] [review] Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" />
Created attachment 63890 [details] [review] [SIGNED-OFF] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 63891 [details] [review] [SIGNED-OFF] Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" /> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 64152 [details] [review] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 64153 [details] [review] Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" /> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09. Please sign-off on bug 18710!
Pushed to 16.05.x, for 16.05.15 release