See bug 8612: (Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines.
Created attachment 76373 [details] [review] Bug 18720: Use exception instead of die in GetBasketAsCsv Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t
Created attachment 81296 [details] [review] Bug 18720: Use exception instead of die in GetBasketAsCsv Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 81406 [details] [review] Bug 18720: Use exception instead of die in GetBasketAsCsv Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.13