The system preferences AcqItemSetSubfieldsWhenReceiptIsCancelled and AcqItemSetSubfieldsWhenReceived loose part of their values because of double quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated)
The problem occurs with all system preferences containing double quotes as values. The values are correct in the database but are truncated if edited again. Other example is Bug 9814 - KohaAdminEmailAddress syspref webpage field doesn't handle double quotes.
Created attachment 63956 [details] [review] Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref)
Setting to major because users can unintentionally change system preferences to mutilated values.
*** Bug 9814 has been marked as a duplicate of this bug. ***
Created attachment 63958 [details] [review] [SIGNED-OFF] Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 64144 [details] [review] Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09.
Pushed to 16.05.x, for 16.05.15 release