To reproduce: - Go to Home > Reports > Cash register statistics - Select a date range - Output to screen in browser: Displays OK - Output to a file: Internal Server Error Plack error log says: CGI::param called in list context from package CGI::Compile::ROOT::home_marc_koha_reports_cash_register_stats_2epl line 64, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_marc_koha_reports_cash_register_stats_2epl line 66, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. exited nonzero: 1 at /home/marc/koha/reports/cash_register_stats.pl line 201.
The internal server error can be fixed by changing line 174 from exit(1); to exit(0); But then an new issue appears: The export has an empty line above the header line, and the header line is mixed with and without double quotes: mfirstname;card number;firstname;branchname;date;accounttype;amount;title;barcode;"itype"
Created attachment 64137 [details] [review] Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed
Created attachment 64142 [details] [review] Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 64146 [details] [review] Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 64230 [details] [review] Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09.
Patchset has conflicts, skipping for 16.05.x
(In reply to Mason James from comment #9) > Patchset has conflicts, skipping for 16.05.x depends on BZ 6934