When Elasticsearch is not configured/not running, executing prove -v t/db_dependent/Koha_Elasticsearch_Indexer.t fails with the same error message as indicated in Bug 12478 ([NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61) Leaving the Elasticsearch koha-conf values empty creates same failure.
Created attachment 74118 [details] [review] Bug 18738: Improve failure cases to skip better TEST PLAN --------- no elasticsearch section in koha-conf.xml prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- nasty elasticsearch, but no nodes prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- ugly apply patch re-run above cases -- unique skips run qa test tools
Created attachment 74121 [details] [review] Bug 18738: Improve failure cases to skip better TEST PLAN --------- no elasticsearch section in koha-conf.xml prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- nasty elasticsearch, but no nodes prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- ugly apply patch re-run above cases -- unique skips run qa test tools
Patch doesn't apply Applying: Bug 18738: Improve failure cases to skip better Using index info to reconstruct a base tree... A t/db_dependent/Koha_Elasticsearch_Indexer.t Falling back to patching base and 3-way merge... CONFLICT (modify/delete): t/db_dependent/Koha_Elasticsearch_Indexer.t deleted in HEAD and modified in Bug 18738: Improve failure cases to skip better. Version Bug 18738: Improve failure cases to skip better of t/db_dependent/Koha_Elasticsearch_Indexer.t left in tree. error: Failed to merge in the changes. Patch failed at 0001 Bug 18738: Improve failure cases to skip better
Hi Hayley, if a patch doesn't apply, you can use the status "Patch doesn't apply" . Thx for your testing!
Hi, can author rebase this on master, please? Thank you.
Test file Koha_Elasticsearch_Indexer.t no longer exists.