It seems like a few lines were lost from issues-stats.pl in bug 7679: # footer print "TOTAL"; $cols = @$results[0]->{loopfooter}; print map {$sep.$_->{totalcol}} @$cols; print $sep.@$results[0]->{total};
Created attachment 64081 [details] [review] Bug 18742 - Circulation statistics wizard no longer exports the total row To test: Run the circulation wizard Export to csv Note there is no total row Apply patch Export to csv Total row totally there!
Regarding bug 7679 this line was wrong, that is why it has been removed.
Created attachment 65938 [details] [review] [SIGNED OFF] Bug 18742 - Circulation statistics wizard no longer exports the total row To test: Run the circulation wizard Export to csv Note there is no total row Apply patch Export to csv Total row totally there! Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> :call TrimWhiteSpace()
(In reply to Jonathan Druart from comment #2) > Regarding bug 7679 this line was wrong, that is why it has been removed. It looks like it has been removed by accident while resolving a merge conflict. The commit that remove those lines doesn't mention this change. I believe the TOTAL row has been fixed by bug 7679, but even if it's wrong, the same data should appear on screen and in the CSV export (and the TOTAL row is already displayed on screen).
Created attachment 66746 [details] [review] Bug 18742: Circulation statistics wizard no longer exports the total row To test: - Run the circulation wizard - Export to csv - Note there is no total row - Apply patch - Export to csv - Total row totally there! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 66747 [details] [review] Bug 18742: (QA followup) Fix indentation Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.