To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/ArticleRequests.t => FAIL: itemtype-related warnings raised.
Created attachment 64134 [details] [review] Bug 18766: Remove itemtype-related warnings from ArticleRequests.t This patch fixes a small mistake on that test file (itype vs. itemtype in itemtypes table) To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/ArticleRequests.t => FAIL: itemtype-related warning displayed - Apply the patch - Run k$ prove t/db_dependent/ArticleRequests.t => SUCCESS: No warnings, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 64135 [details] [review] Bug 18766: Remove itemtype-related warnings from ArticleRequests.t This patch fixes a small mistake on that test file (itype vs. itemtype in itemtypes table) To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/ArticleRequests.t => FAIL: itemtype-related warning displayed - Apply the patch - Run k$ prove t/db_dependent/ArticleRequests.t => SUCCESS: No warnings, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
Patch doesn't apply cleanly to 16.11.x - please check if it's needed there and rebase.
Problem here stems from the dependencies not being in 16.11.x, because they don't apply. Closing.