Created attachment 64136 [details] [review] Bug 18767: Remove useless diags from GetDailyQuote.t This tests print useless debugging info. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/GetDailyQuote.t => FAIL: Some output telling what is doing on each step is printed. - Apply the patch - Run k$ prove t/db_dependent/Koha/GetDailyQuote.t => SUCCESS: No output, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment on attachment 64136 [details] [review] Bug 18767: Remove useless diags from GetDailyQuote.t Review of attachment 64136 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/Koha/GetDailyQuote.t @@ +86,5 @@ > is( $quote->{id}, 6, ' GetDailyQuote returns the only existing quote' ); > > $dbh->rollback; > + > +1; See bug 18292.
Created attachment 64139 [details] [review] Bug 18767: Remove useless diags from GetDailyQuote.t This tests print useless debugging info. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/GetDailyQuote.t => FAIL: Some output telling what is doing on each step is printed. - Apply the patch - Run k$ prove t/db_dependent/Koha/GetDailyQuote.t => SUCCESS: No output, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 64145 [details] [review] Bug 18767: Remove useless diags from GetDailyQuote.t This tests print useless debugging info. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/GetDailyQuote.t => FAIL: Some output telling what is doing on each step is printed. - Apply the patch - Run k$ prove t/db_dependent/Koha/GetDailyQuote.t => SUCCESS: No output, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09.
Pushed to 16.05.x, for 16.05.15 release