The password reset notice currently uses the email address stored in the KohaAdminEmailAddress system preference as the "from" address. This can be confusing to patrons (or even make them suspicious) since it may not be the same address (or even the same domain) as the rest of their email notices. This enhancement would use the "from" address set for the patron's home branch and only use the Koha Admin Email Address as a fallback if there is not an address set for the home branch.
Created attachment 64173 [details] [review] Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender.
Created attachment 64875 [details] [review] Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman <jessicafreeman@catalyst.net.nz>
Created attachment 65024 [details] [review] Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman <jessicafreeman@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 65025 [details] [review] Bug 18775: Use Koha::Patron->library instead of Koha::Libraries->find Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x
Hm, I think we should really use Koha::Email here to have the same logic as other emails. There is another related bug 18988, also commenting there.
(In reply to Katrin Fischer from comment #7) > Hm, I think we should really use Koha::Email here to have the same logic as > other emails. There is another related bug 18988, also commenting there. Sigh - after looking at the code more closely, that is nonsense. The password reset emails are using the message_queue which makes them work just like they should.
hi, i've made all set that you guys mentioned there but i can't make it work, if i use this command: "echo "TEST MAIL" | mail -s "Email test subject" myemail@domain.com" I got email in my account gmail, but when i try to use "forgotten password" koha (opac) says that i'll recieve an email, but i got nothing, i hope you can help me, i have more than a week trying to make it work, thanks
VikDC: This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/