The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] "
Created attachment 64190 [details] [review] Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po
Hm, could we generally exclude every element starting with [%% instead of doing those one by one?
(In reply to Katrin Fischer from comment #2) > Hm, could we generally exclude every element starting with [%% instead of > doing those one by one? Line breaks inside template directives are not easy to cover by the translation process. You can not skip them because they can contain particles that should be translated. See following comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559#c1 Jonathan recently added a test to QA tools. The newest version checks for line breaks inside tt directives. It makes sense to weed out such tt directives because translators should not be exposed to such code internals. BTW: For OPAC, all occurences of "[%%" are fixed with my series of patches (search for: translatability). For staff, most work is done as well.
Still applies on current master
Created attachment 65398 [details] [review] [SIGNED-OFF] Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 66642 [details] [review] Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc exposes template directives to translation where translators should not be confronted with. Example: "[%% PROCESS showreference heading=seeals.heading linkType='seealso' " "type=seeals.type authid=seeals.authid %%] " To test: - Apply patch - Verify that Authority search in OPAC works as before - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
This patch has been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release