Bug 18796 - Allow to print notice while claiming serials
Summary: Allow to print notice while claiming serials
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-13 14:35 UTC by Julian Maurice
Modified: 2022-07-30 20:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18796: Allow to print notice while claiming serials (10.67 KB, patch)
2017-06-13 14:36 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 18796: Allow to print notice while claiming serials (10.81 KB, patch)
2017-06-13 17:00 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 18796: Allow to print notice while claiming serials (11.04 KB, patch)
2021-09-17 13:51 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2017-06-13 14:35:37 UTC
It can be useful to have a printable version of a claim notice, for testing purposes or for when supplier has no email address for example
Comment 1 Julian Maurice 2017-06-13 14:36:05 UTC
Created attachment 64261 [details] [review]
Bug 18796: Allow to print notice while claiming serials

It can be useful to have a printable version of a claim notice, for
testing purposes or for when supplier has no email address for
example

Test plan:
1. Go to Serials > Claims and select a vendor
2. Select some serials by clicking on checkboxes
3. Click to the little arrow next to 'Send notification' button and
   click on 'Print notification'
4. Verify that the downloaded PDF contains the content of the selected
   notice
5. Verify that the 'Send notification' button still works as before
6. Run `prove t/db_dependent/Letters.t`
Comment 2 Marc Véron 2017-06-13 17:00:39 UTC
Created attachment 64263 [details] [review]
Bug 18796: Allow to print notice while claiming serials

It can be useful to have a printable version of a claim notice, for
testing purposes or for when supplier has no email address for
example

Test plan:
1. Go to Serials > Claims and select a vendor
2. Select some serials by clicking on checkboxes
3. Click to the little arrow next to 'Send notification' button and
   click on 'Print notification'
4. Verify that the downloaded PDF contains the content of the selected
   notice
5. Verify that the 'Send notification' button still works as before
6. Run `prove t/db_dependent/Letters.t`

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Fridolin Somers 2019-07-04 10:11:09 UTC
Rebase looks easy ;)
Comment 4 Fridolin Somers 2020-08-26 13:48:37 UTC
ah JavaScript should be at bottom ;)
Comment 5 Fridolin Somers 2021-06-23 12:10:11 UTC
Needs a huge rebase :D
Comment 6 Julian Maurice 2021-09-17 13:21:53 UTC
(In reply to Fridolin Somers from comment #3)
> Rebase looks easy ;)

(In reply to Fridolin Somers from comment #5)
> Needs a huge rebase :D

What two years of changes can do... :)
Comment 7 Julian Maurice 2021-09-17 13:51:33 UTC
Created attachment 124988 [details] [review]
Bug 18796: Allow to print notice while claiming serials

It can be useful to have a printable version of a claim notice, for
testing purposes or for when supplier has no email address for
example

Test plan:
1. Go to Serials > Claims and select a vendor
2. Select some serials by clicking on checkboxes
3. Click to the little arrow next to 'Send notification' button and
   click on 'Print notification'
4. Verify that the downloaded PDF contains the content of the selected
   notice
5. Verify that the 'Send notification' button still works as before
6. Run `prove t/db_dependent/Letters.t`

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 8 Julian Maurice 2021-09-17 13:52:10 UTC
Patch rebased on master
Comment 9 Katrin Fischer 2021-10-21 20:17:35 UTC
Hi Julian,

I've tried adding some basic formatting, but in the output it comes out as: 

Printtest
<b>Print</b>

<div style="background:red">
test
</div>

So there are no line breaks for the div element and the bold formatting is also lost. 

Can you tell if I am doing something wrong there?
Comment 10 Katrin Fischer 2022-07-30 20:00:48 UTC
Ping?