Bug 18832 - Missing space between icon and label in button 'Patron lists'
Summary: Missing space between icon and label in button 'Patron lists'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2017-06-21 07:39 UTC by Marc Véron
Modified: 2018-12-03 20:03 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Screenshot with button 'Patron lists' (7.66 KB, image/png)
2017-06-21 07:39 UTC, Marc Véron 		Details
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.25 KB, patch)
2017-06-21 07:49 UTC, Marc Véron 		Details | Diff | Splinter Review
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.30 KB, patch)
2017-06-28 13:40 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 18832: Missing space between icon and label in button 'Patron lists' (1.37 KB, patch)
2017-07-07 08:02 UTC, Julian Maurice 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2017-06-21 07:39:40 UTC 
Created attachment 64483 [details]
Screenshot with button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between the Icon and the text. See screenshot attached.
Comment 1 Marc Véron 2017-06-21 07:49:38 UTC 
Created attachment 64485 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.
Comment 2 Frederique Couffignal 2017-06-28 13:37:16 UTC 
Space on button ok
Action on button is ok too
Comment 3 Biblibre Sandboxes 2017-06-28 13:40:11 UTC 
Patch tested with a sandbox, by fcouffignal <fcouffignal@gmail.com>
Comment 4 Biblibre Sandboxes 2017-06-28 13:40:35 UTC 
Created attachment 64702 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.

Signed-off-by: fcouffignal <fcouffignal@gmail.com>
Comment 5 Julian Maurice 2017-07-07 08:02:52 UTC 
Created attachment 64890 [details] [review]
Bug 18832: Missing space between icon and label in button 'Patron lists'

On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.

To test, apply patch and verify that the button displays as expected.

Signed-off-by: fcouffignal <fcouffignal@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Jonathan Druart 2017-07-17 19:13:24 UTC 
Pushed to master for 17.11, thanks to everybody involved!
Comment 7 Fridolin Somers 2017-07-27 14:31:48 UTC 
Pushed to 17.05.x, will be in 17.05.03.
Comment 8 Katrin Fischer 2017-08-01 05:31:06 UTC 
Patch adapted for 16.11.x (buttons are different)

This patch has been pushed to 16.11.x and will be in 16.11.11.
Comment 9 Mason James 2017-08-24 13:55:15 UTC 
Pushed to 16.05.x, for 16.05.16 release