Created attachment 64684 [details] Patron clubs interface showing tables The tables for patron clubs and club templates should not show at all if they are empty. Also the clubs table is slightly broken. See screenshot.
Created attachment 64687 [details] [review] Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT
It looks good. REPRODUCE OUTPUT QUESTION: Add a template Add a club Delete a club Just quick question. If there are no templates or clubs, should it not revert to this new style of nothing? Or is this okay? If it is okay, then I'll sign off. If it should revert to the initial nothing style, then this needs a tweak.
Created attachment 64936 [details] [review] Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT
Created attachment 64946 [details] [review] Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons
Created attachment 65443 [details] [review] [SIGNED-OFF] Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 65444 [details] [review] [SIGNED-OFF] Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 65445 [details] [review] [SIGNED-OFF] Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
I figured I wouldn't let it languish.
Created attachment 66650 [details] [review] Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66651 [details] [review] Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66652 [details] [review] Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x