When both bug 14533 and bug 9409 are applied, the comment added in 14533 becomes incorrect.
Created attachment 64715 [details] [review] Bug 18877: Outdated explanation of use when tow patches applied TEST PLAN --------- apply bugs 9409 and 14533 (order is irrelevant) trigger message about missing database name -- notice it fails to mention dbhost apply this patch trigger message again -- notice it mentions dbhost
testing 2 commit(s) (applied to 3d24c19 'Bug 14533: remove CREATE USER when ko') Processing files before patches Processing files after patches kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ It appears that applying this patch breaks QA Tools for some reason. Failing QA
Bash files are not part of the QA Test tools suite.
(In reply to Lee Jamison from comment #2) > testing 2 commit(s) (applied to 3d24c19 'Bug 14533: remove CREATE USER when > ko') > > Processing files before patches > > Processing files after patches > > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ > > > It appears that applying this patch breaks QA Tools for some reason. > > Failing QA This is not relevant, nothing is displayed because no file are processed. You can consider that as a bug in the QA script.
Created attachment 65923 [details] [review] Bug 18877: Add documentation on dbhost for koha-create help TEST PLAN --------- apply bugs 9409 and 14533 (order is irrelevant) trigger message about missing database name -- notice it fails to mention dbhost apply this patch trigger message again -- notice it mentions dbhost Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Trivial string change, passing QA.
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x