If you have the superlibrarian or budget_manage_all permission you should be able to see all funds at all times - otherwise it's not possible to centrally manage and edit funds in a multi-branch system. Also, if someone logged themselves out from a fund by wrong configuration, users with those permissions need to be able to fix it. To test: - Make sure your user has superlibrarian permission - Go into acquisisitions - Create a new budget - Create a new fund - set library to 'not your home library' - set restricted to 'owner, users and library' - Verify that after saving the fund, you can no longer access it. - Change your home branch - log out and log in again - Verify you can now see the fund Repeat with all acq permissions including budget_manage_all - you will also experience that you are logged out from accessing the fund you created. Note: visibility on the acq start page will work correctly in these scenarios.
Created attachment 64874 [details] [review] Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget
I do not provide a test plan as I am not sure what is the expected behaviours.
Created attachment 65288 [details] [review] Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 65361 [details] [review] Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Permissions could be more thought out, but this ensures that superlibrarians and users that can manage_all_budgets can access any fund to correct permissions/add users/etc.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.04.
This patch has been pushed to 16.11.x and will be in 16.11.12.
Pushed to 16.05.x, for 16.05.17 release