The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis.
Created attachment 64915 [details] [review] Bug 18909 - Enable the maximum zebra records size to be specified per instance The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis. Test Plan: 1) Apply this patch 2) Build a Debian package 3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml 4) Index a record greater than 1 MB but smaller than 2 MB 5) Note that it is searchable!
Created attachment 72493 [details] [review] Bug 18909 - Enable the maximum zebra records size to be specified per instance The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis. Test Plan: 1) Apply this patch 2) Build a Debian package 3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml 4) Restart zebra 5) Index a record greater than 1 MB but smaller than 2 MB 6) Note that it is searchable!
Created attachment 84284 [details] [review] Bug 18909: Enable the maximum zebra records size to be specified per instance The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis. Test plan for kohadevbox: 1) Apply this patch 2) Run: $ reset_all 3) Restart Zebra: $ sudo koha-zebra --restart kohadev 4) Check how zebrasrv was called: $ ps waux | grep zebrasrv => SUCCESS: Looks like ... /usr/bin/zebrasrv -v none,fatal,warn -k 1024 5) Edit /etc/koha/sites/kohadev/koha-conf.xml, add: <zebra_max_record_size>2048</zebra_max_record_size> 6) Repeat (3) and (4) => SUCCESS: Looks like ... /usr/bin/zebrasrv -v none,fatal,warn -k 2048 7) Sign off :-D General test plan: 1) Apply this patch 2) Build a Debian package 3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml 4) Restart zebra 5) Index a record greater than 1 MB but smaller than 2 MB 6) Note that it is searchable! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 84348 [details] [review] Bug 18909: Enable the maximum zebra records size to be specified per instance The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis. Test plan for kohadevbox: 1) Apply this patch 2) Run: $ reset_all 3) Restart Zebra: $ sudo koha-zebra --restart kohadev 4) Check how zebrasrv was called: $ ps waux | grep zebrasrv => SUCCESS: Looks like ... /usr/bin/zebrasrv -v none,fatal,warn -k 1024 5) Edit /etc/koha/sites/kohadev/koha-conf.xml, add: <zebra_max_record_size>2048</zebra_max_record_size> 6) Repeat (3) and (4) => SUCCESS: Looks like ... /usr/bin/zebrasrv -v none,fatal,warn -k 2048 7) Sign off :-D General test plan: 1) Apply this patch 2) Build a Debian package 3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml 4) Restart zebra 5) Index a record greater than 1 MB but smaller than 2 MB 6) Note that it is searchable! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hugo Agud <hagud@orex.es> Current status: Signed Off
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
I prefer not to change the configuration in 17.11.x since its oldoldstable