Bug 18152 created a regression on z39.50 derivate cataloguing in Unimarc. Now if I derivate from a z39.50 with source date in ISO5426, data are imported well in table "import_record". But if I try to see the with ../catalogue/showmarc.pl or import them into cataloguing form with ../cataloguing/z3950_search.pl#, date are converted in a wrong way. To see the bug you need: -- a Unimarc setup -- as languge 'en' is ok -- a z39.50 server with ISO5426 encoding, for example: Hostname: catalogo.bnportugal.pt Port: 210 Db: bn Syntax: UNIMARC Encoding: ISO_5426 In fact you can cancel this problem on z39.50 with this diff: diff --git a/Charset.pm_old b/Charset.pm index 50d8266..9212aeb 100644 --- a/Charset.pm_old +++ b/Charset.pm @@ -324,6 +324,7 @@ sub SetMarcUnicodeFlag { my $marc_record = shift; my $marc_flavour = shift; # || C4::Context->preference("marcflavour"); + $marc_record->encoding('UTF-8'); if ($marc_flavour eq 'MARC21' || $marc_flavour eq 'NORMARC') { my $leader = $marc_record->leader(); substr($leader, 9, 1) = 'a'; But I think the bug is more complex, probably a revert is not enough.
This bug is not easy to find. Here the mail thread about it: http://koha.1045719.n5.nabble.com/Z39-50-encoding-problem-tested-on-2-koha-servers-td5938540.html The bug is present on 16.11, 17.05 and master
Created attachment 65083 [details] [review] Bug 18910: Revert "Bug 18152: Add tests" This reverts commit a807d7199ea025aa507e0ca7e3ff2330902844f8.
Created attachment 65084 [details] [review] Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" This reverts commit bf551a07222a7b9beffd7ca6cba38c675aa3ab28.
Jonathan, OK on revert, but I sugggest also a comment about bad Unimard haldling in MARC::Record library.
Created attachment 65102 [details] [review] Bug 18910: Revert "Bug 18152: Add tests" This reverts commit a807d7199ea025aa507e0ca7e3ff2330902844f8. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 65103 [details] [review] Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" This reverts commit bf551a07222a7b9beffd7ca6cba38c675aa3ab28. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Skipping QA, we need it in the next stable releases.
Patches pushed to master for 17.11
I'll push to 16.05.x branch
Pushed to 17.05.x, will be in 17.05.02. Tested on UNIMARC db with BNF z3950 like in our demo : https://intranet-demo.biblibre.com
These patches have been pushed to 16.11.x and will be in 16.11.10.
Pushed to 16.05.x, for 16.05.15 release