When you export (tools -> export data) biblios in a CSV file format, koha breaks and gives this error in the error log: There is no valid csv profile defined for this export at /home/vagrant/kohaclone/Koha/Exporter/Record.pm line 146.
Created attachment 64945 [details] [review] Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT
Created attachment 64964 [details] [review] Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 65027 [details] [review] Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.03. Nice.
This patch has been pushed to 16.11.x and will be in 16.11.10.
Sorry, 16.11.11!
Pushed to 16.05.x, for 16.05.16 release