The koha-config values for DB_USE_TLS and FONT_DIR (for dejavu fonts) are not being saved in koha_install_log so the user is prompted for them when running perl Makefile.PL --prev-install-log ~/etc/koha/misc/koha-install-log they should be written to koha-install-log so that, like other config values they are not prompted for after initially being set
Created attachment 64956 [details] [review] Patch to add missing values to install log To test - without patch applied when running Makefile.PL --prev-install-log /path/to/misc/koha-install-log user will always be prompted for whether db connection uses TLS and the location of DejaVu fonts With patch applied (and assuming the path is /etc/koha/misc substitute as required) run perl Makefile.PL --prev-install-log /etc/koha/misc/koha-install-log prompts for the above values will appear answer as before do a make upgrade rerun perl Makefile.PL -prev-install-log /etc/koha/misc/koha-install-log these variables are now read from the install log and not prompted for inspecting the installed koha-install.log there will now be values for DB_USE_TLS and FONT_DIR - there are also entries for DB_TLS_CA_CERTIFICATE, DB_TLS_CLIENT_CERTIFICATE and DB_TLS_CLIENT_KEY but these will only be set if DB_USE_TLS is set to yes
NOTE: Untestable in a SYNC_REPO Windows Dev Box, due to ::'s in the man pages.
Created attachment 68181 [details] [review] Bug 18920 Save DB_USE_TLS and FONT_DIR to install log Configuration values should be included in the koha-install-log so that when running Makefile.PL with the --prev-install-log option values can be read from there and reapplied rather than prompting the user on each subsequent run. This adds FONT_DIR and DB_USE_TLS (and its dependent options) to koha-install-log so that the set values will be written by make during a make install or make upgrade Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 68716 [details] [review] Bug 18920 Save DB_USE_TLS and FONT_DIR to install log Configuration values should be included in the koha-install-log so that when running Makefile.PL with the --prev-install-log option values can be read from there and reapplied rather than prompting the user on each subsequent run. This adds FONT_DIR and DB_USE_TLS (and its dependent options) to koha-install-log so that the set values will be written by make during a make install or make upgrade Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!