Created attachment 64961 [details] [review] Bug 18923: Warning in Biblio::GetCOinSBiblio Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. Test plan: Enable COinSinOPACResults. Without this patch, do some opac searches. Check the log. Apply this patch, search again and check the log.
Tried to test this, but was not able to make the warn show in the logs on kohadevbox. Checked koha-plack-err and koha-opac-err. Also made sure my result list had some records with 773 (analytics)
(In reply to Katrin Fischer from comment #2) > Tried to test this, but was not able to make the warn show in the logs on > kohadevbox. Checked koha-plack-err and koha-opac-err. > Also made sure my result list had some records with 773 (analytics) Enable COinSinOPACResults. Make sure that either 773a or 773t is not there.
Sorry, but already did that :(
(In reply to Katrin Fischer from comment #4) > Sorry, but already did that :( And without this patch, perform some opac searches (that include the record with incomplete 773)
Hm, misread, NOT there. Will try that later.
My record had a 773 like this: <datafield tag="773" ind1="1" ind2="8"> <subfield code="w">000621110</subfield> <subfield code="g">3</subfield> <subfield code="q">3,2</subfield> </datafield> Still no luck. Can you please test again? Maybe another patch fixed it.
(In reply to Katrin Fischer from comment #7) > My record had a 773 like this: > > <datafield tag="773" ind1="1" ind2="8"> > <subfield code="w">000621110</subfield> > <subfield code="g">3</subfield> > <subfield code="q">3,2</subfield> > </datafield> > > Still no luck. Can you please test again? Maybe another patch fixed it. Aah. Found it: This part of code in GetCOinSBiblio only is touched when some leader values are set. Position 6 should be a and position 7 should be a. Note: First test without the patch. Then apply and test again. The warning should not be generated in the latter case. Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1370. Will adjust the test plan accordingly.
Created attachment 67835 [details] [review] Bug 18923: Warning in Biblio::GetCOinSBiblio Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. Note: In current master this is now line 1370 (Oct 9, 2017). Test plan: Enable COinSinOPACResults. Select a record with leader pos6==a and pos7==a. This triggers genre to be journalArticle and titletype to be a. Without this patch, do an opac search that includes this record. Check the log. You should see the warning. Apply this patch, search again and check the log. The warning should not be repeated again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 67999 [details] [review] Bug 18923: Warning in Biblio::GetCOinSBiblio Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. Note: In current master this is now line 1370 (Oct 9, 2017). Test plan: Enable COinSinOPACResults. Select a record with leader pos6==a and pos7==a. This triggers genre to be journalArticle and titletype to be a. Without this patch, do an opac search that includes this record. Check the log. You should see the warning. Apply this patch, search again and check the log. The warning should not be repeated again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 68070 [details] [review] Bug 18923: Warning in Biblio::GetCOinSBiblio Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. Note: In current master this is now line 1370 (Oct 9, 2017). Test plan: Enable COinSinOPACResults. Select a record with leader pos6==a and pos7==a. This triggers genre to be journalArticle and titletype to be a. Without this patch, do an opac search that includes this record. Check the log. You should see the warning. Apply this patch, search again and check the log. The warning should not be repeated again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!
Not backported?
(In reply to Marcel de Rooy from comment #13) > Not backported? Oh I missed it.
Pushed to 17.05.x for 17.05.08
Pushed to 16.11.x will be in 16.11.16
Hmm. In 17.05.x I still find this bug labeled as 18923, but in 16.11.x it pops up under 18922 ? What happened ?
(In reply to Marcel de Rooy from comment #17) > Hmm. In 17.05.x I still find this bug labeled as 18923, but in 16.11.x it > pops up under 18922 ? What happened ? Whooo indeed, i dont understand because cherry-picked SHA is OK