This is inconsistent with the Staff Client side, where the SMS number can be set to empty. Also I think that since this is borrower information, it should be their choice whether they provide this info or not and should have the ability to remove it
Created attachment 65014 [details] [review] Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT
Hey, I can't manage to recreate the bug. after doing steps 1) to 4), I enter a number, save it, refresh the page again(F5), delete the number, refresh it again(F5) but the field for the number is indeed empty. Please tell me if there is any information not specified in the test plan I should be aware of.
(In reply to Dominic Pichette from comment #2) > Hey, > > I can't manage to recreate the bug. after doing steps 1) to 4), I enter a > number, save it, refresh the page again(F5), delete the number, refresh it > again(F5) but the field for the number is indeed empty. > > Please tell me if there is any information not specified in the test plan I > should be aware of. I can still recreate this bug. Are you sure you are testing this on the OPAC?
Yes, I am in the Opac and the patch has not been installed. I attached two pictures. withoutpatch_1.png shows that the number is really saved in the field and withoutpatch_2.png shows that once the field is saved without a number in it, the field is indeed updated.
Cannot reproduce on master.
I have been able to verify that this bug only occurs if SMSSendDriver is set to Email.
Created attachment 98628 [details] [review] Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT
Created attachment 98642 [details] [review] Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99133 [details] [review] Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.04
backported to 19.05.x for 19.05.09