If the AcquisitionDetails system preference is used, there is an extra tab on the staff details page displaying information about the acquisition orders linked to this bibliographic record. It would be nice if the internal note from the order would be displayed there as well.
Created attachment 84751 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows
Created attachment 84755 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings
Works well but needs one correction: missing_filter at line 773 ( <td>[% order.order_internalnote %]</td>)
(In reply to Owen Leonard from comment #3) > Works well but needs one correction: > > missing_filter at line 773 ( <td>[% order.order_internalnote > %]</td>) you are so right *hides*
Created attachment 84806 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings
Since the patch and the change are so smal, I've amended the patch with the filter.
Created attachment 84901 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Thx Maryse!
Created attachment 85195 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 85825 [details] [review] Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.