Dear All, I have activated the renewal date in messages, but if a member renewed the book from koha staf client it reflect the Time of renewal but not if book is renewed online. Please suggest (Koha 16.11.07). Renewal message through Koha staff client : The following Book/s have been renewed on 19/07/2017 10:37: Renewal Message through OPAC : The following Book/s have been renewed on 19/07/2017 00:00: (Time is missing here)
What notice template are you using for RENEWAL?
I am using the following template in my defined library "Dear Patron, The following Book/s have been renewed on <<issues.lastreneweddate>>: ---- <<biblio.title>>" ----
I am seeing "The following items have been renewed on 10/10/2017 00:00" From both OPAC and staff interface. You must use the "dateonly" filter if you want to get rid of the time part (00:00): The following items have been renewed on <<issues.lastreneweddate | dateonly >>
Ok, But what if i need time part also to have some reason/observation on user activities on renewal time? At least staff if renewed from staff slient it shows time but not if renewed from OPAC. Hope this may be a genuine bug to resolve.
(In reply to Vinod from comment #4) > At least staff if renewed from staff slient it shows time but not if renewed > from OPAC. Are you sure? How? I do not see the time part, even if renewed from the staff side.
Yes Jonathan, i can see the time when renewed from staff client, but now i have to check the behavior again and i have upgraded to Koha 16.11.11.
I've done some tests: - Renew from OPAC - Renew from staff: patron account - Renew from staff: renewal tab In all cases the time of the renewal was not recorded. The column issues.datelastrenewed is a datetime datatype, so it gets set to 00:00:00. This is a bit irritating. Maybe we could fix it to record not only the date, but the time as well?
Created attachment 85527 [details] [review] Bug 18957: Add tests
Created attachment 85528 [details] [review] Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly
Created attachment 85565 [details] [review] Bug 18957: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 85566 [details] [review] Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 85598 [details] [review] Bug 18957: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85599 [details] [review] Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
Doesn't apply cleanly to 18.05.x. Please rebase to 18.05.x if needed.