This is needed for bugs 18055 and 18979
Mirko, can you do this one please?
Created attachment 65296 [details] [review] Bug 18993 - Bump libtest-simple-perl to 1.302075
I have backported libtest-simple-perl 1.302075-2 from Debian Unstable and uploaded it to all repositories. Version in Debian Jessie was only 1.001008-1.
Created attachment 65331 [details] [review] Bug 18993 - Bump libtest-simple-perl to 1.302075
Perl core has a sufficient version in v5.25.8 > corelist -a Test::Simple > […] > v5.25.8 1.302073 For Debian that means perl-modules-5.26 will be the first alternative to libtest-simple-perl 1.302075. This should be reflected in debian/control(.in)
> > v5.25.8 1.302073 Obviously the version is lower … my bad.
Created attachment 65333 [details] [review] Bug 18993 - Bump libtest-simple-perl to 1.302075 Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to Mason James from comment #7) > Created attachment 65333 [details] [review] [review] > Bug 18993 - Bump libtest-simple-perl to 1.302075 > > Signed-off-by: Mason James <mtj@kohaaloha.com> looks good Mirko, thanks!
'Test::More' => { 'usage' => 'Core', 'required' => '1', 'min_ver' => '0.8' }, Shouldn't we upgrade the min_ver for this one here too ? Needs feedback
Marcel, I do not understand. This bug report is about Test::Simple. 0.8 is old instead, but why do we need to fix it now?
(In reply to Marcel de Rooy from comment #9) > 'Test::More' => { > 'usage' => 'Core', > 'required' => '1', > 'min_ver' => '0.8' > }, > > Shouldn't we upgrade the min_ver for this one here too ? > > Needs feedback hi Marcel, the short answer is no Test::Simple has no dependency on Test::More, therefore there is no need to upgrade Test::More https://packages.debian.org/jessie/libtest-simple-perl https://packages.debian.org/stretch/libtest-simple-perl ..does that make sense?
(In reply to Mason James from comment #11) > (In reply to Marcel de Rooy from comment #9) > > 'Test::More' => { > > 'usage' => 'Core', > > 'required' => '1', > > 'min_ver' => '0.8' > > }, > > > > Shouldn't we upgrade the min_ver for this one here too ? > > > > Needs feedback > > hi Marcel, the short answer is no > > Test::Simple has no dependency on Test::More, therefore there is no need to > upgrade Test::More > > https://packages.debian.org/jessie/libtest-simple-perl > https://packages.debian.org/stretch/libtest-simple-perl > > ..does that make sense? Hey MJ, When I follow that link, I see that libtest-simple-perl includes Test::More ! Marcel
Created attachment 67563 [details] [review] Bug 18993: Bump Test::More to 1.302075
So, moving on now?
(In reply to Jonathan Druart from comment #14) > So, moving on now? yes, looks good :)
(In reply to Mirko Tietgen from comment #6) > > > v5.25.8 1.302073 > > Obviously the version is lower … my bad. The patch still references perl-modules-5.26 as an alternative to libtest-simple-perl. Shouldn't it be removed ? If 1.302073 is ok I think we should use that version in PerlDependencies.pm and debian/control
Failing for comment 16
(In reply to Julian Maurice from comment #16) > (In reply to Mirko Tietgen from comment #6) > > > > v5.25.8 1.302073 > > > > Obviously the version is lower … my bad. > > The patch still references perl-modules-5.26 as an alternative to > libtest-simple-perl. Shouldn't it be removed ? > If 1.302073 is ok I think we should use that version in PerlDependencies.pm > and debian/control good news.. the tests PASS with 1.302073 i'll add a patch with the correction
Created attachment 69173 [details] [review] Bug 18993: Allow Test::More version 1.302073
setting to status back to SO? good spotting Julian!
libtest-simple-perl is listed twice in Build-Depends (debian/control), the first without version constraint (comes from __AUTODEPENDS__). This is probably nothing but maybe lintian will complain about that. But it's already like that in master, so this will not prevent QA.
Created attachment 69175 [details] [review] Bug 18993 - Bump libtest-simple-perl to 1.302075 Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 69176 [details] [review] Bug 18993: Bump Test::More to 1.302075 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 69177 [details] [review] Bug 18993: Allow Test::More version 1.302073 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
What is the current status here? This seems to be needed for two bugs which are blocked/in discussion..
Ah I forgot to change status to Passed QA. Fixed! Thanks Marcel
Pushed to master for 18.05, thanks to everybody involved!
Skipping for 17.11
(In reply to Julian Maurice from comment #16) > (In reply to Mirko Tietgen from comment #6) > > > > v5.25.8 1.302073 > > > > Obviously the version is lower … my bad. > > The patch still references perl-modules-5.26 as an alternative to > libtest-simple-perl. Shouldn't it be removed ? > If 1.302073 is ok I think we should use that version in PerlDependencies.pm > and debian/control Speaking of perl-modules-5.26 -- I can't follow the https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way instructions to roll a custom package any more. It had perl-modules-5.22 and perl-modules-5.24, but those were removed too. :(
(In reply to M. Tompsett from comment #29) > Speaking of perl-modules-5.26 -- I can't follow the > https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way > instructions to roll a custom package any more. It had perl-modules-5.22 and > perl-modules-5.24, but those were removed too. :( Could you please open a new bug and give more details? (What are you trying to do? build-git-snapshot, something else? Which version of Koha, on which OS in what version? what is expected, what is actually happening?) Please add me to the CC list if you do and I'll have a look.