A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API.
Created attachment 65343 [details] Screenshot - Pre-patch
Created attachment 65344 [details] Screenshot - Post-patch
Created attachment 65345 [details] [review] Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available
Created attachment 65346 [details] [review] Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: George Williams <gwilliams@nekls.org>
Created attachment 66693 [details] [review] Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: George Williams <gwilliams@nekls.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
I can't see the "Pay with Debit or Credit Card" option, but this is probably because of a misconfiguration in my PayPal account. According to the documentation at https://developer.paypal.com/docs/classic/api/merchant/SetExpressCheckout_API_Operation_NVP/ the patch is correct.
Pushed to master for 17.11, thanks to everybody involved!
(In reply to Julian Maurice from comment #6) > I can't see the "Pay with Debit or Credit Card" option, but this is probably > because of a misconfiguration in my PayPal account. According to the > documentation at > https://developer.paypal.com/docs/classic/api/merchant/ > SetExpressCheckout_API_Operation_NVP/ the patch is correct. I bet this is because you have a regular french card that is only a debit card. In US and other countries, they are real credit|debit cards.
Pushed to 17.05.x, will be in 17.05.05.
This patch has been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release