In Home > Administration > Circulation and fine rules, the standard value for "Select a library: All libraries" is confusing and leads to support cases. Change wording to "Standard rules for all libraries". See: Bug 18997 - Everything listed as "not renewable" http://koha.1045719.n5.nabble.com/Impossible-to-renew-items-tc5941578.html
Created attachment 65432 [details] [review] Bug 19027 - Circulation rules: Better wording for standard rules for all libraries In Home > Administration > Circulation and fine rules, the standard value for "Select a library: All libraries" is confusing and leads to support cases. Change wording to "Standard rules for all libraries". To test: - Apply patch - Go to Home > Administration > Circulation and fine rules - Verfiy that text in drop down 'Select a library' makes sense.
Created attachment 65436 [details] [review] Bug 19027 - Circulation rules: Better wording for standard rules for all libraries In Home > Administration > Circulation and fine rules, the standard value for "Select a library: All libraries" is confusing and leads to support cases. Change wording to "Standard rules for all libraries". To test: - Apply patch - Go to Home > Administration > Circulation and fine rules - Verfiy that text in drop down 'Select a library' makes sense. Followed test plan which works as intended. I agree with the wording it is significantly clearer than previously Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Hi Marc I think an additional enhancement would be to hide the 'Clone these rules to: library" if "Standard rules for all libraries" option is selected using javascript, because as the rule is being applied to all libraries cloning them to another library is redundant. What are your thoughts on this?
I think cloning from standard to a specific library in order to then adapt the rules makes sense in some cases, so I wouldn't hide it. But I have seen people hitting the clone button by accident. A security question and maybe slightly different placement of the feature could be helpful.
I agree with your suggestion Katrin :) Marc I'll create a followup patch for this bug report if that's ok with you?
Hm maybe we should put the cloning discussion on a separate bug, so this can move on quickly. Also a little nicer for release notes to have the changes listed separately.
Good idea I'll create a new bug report now
Created attachment 65850 [details] [review] Bug 19027 - Circulation rules: Better wording for standard rules for all libraries In Home > Administration > Circulation and fine rules, the standard value for "Select a library: All libraries" is confusing and leads to support cases. Change wording to "Standard rules for all libraries". To test: - Apply patch - Go to Home > Administration > Circulation and fine rules - Verfiy that text in drop down 'Select a library' makes sense. Followed test plan which works as intended. I agree with the wording it is significantly clearer than previously Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
This patch has been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release