With bug 16759 there's no need to have a syspref for hiding a specific column that doesn't contain sensitive data.
Created attachment 65518 [details] [review] Bug 19038: Remove the OPACShowBarcode syspref This patch removes the OPACShowBarcode syspref in favour of the new columns settings option introduced by bug 16759. On the upgrade step, it picks the value for OPACShowBarcode and uses it to populate the columns_settings table. To test: - Verify the upgrade process maintains the current behaviour Regards Sponsored-by: Dover
Created attachment 66133 [details] [review] Bug 19038: Remove the OPACShowBarcode syspref Followed test plan and works as expected. Functionality of patch from bug 16759 appears intact too. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Created attachment 68476 [details] [review] Bug 19038: QA Followup - Hide barcode column by default (as syspref default is hide)
I think this one is good, however, what I see is that the upgrade is odd. If you have set columns configuration already, this won't set it regardless of syspref so if pref is set to "Don't show" and columns setting is set to show barcode then after this patch the column will show(it was hidden before) I don't know if this matters if both bugs are pushed to same version, can you answer Tomas?
(In reply to Nick Clemens from comment #4) > I think this one is good, however, what I see is that the upgrade is odd. > > If you have set columns configuration already, this won't set it regardless > of syspref so if pref is set to "Don't show" and columns setting is set to > show barcode then after this patch the column will show(it was hidden before) > > I don't know if this matters if both bugs are pushed to same version, can > you answer Tomas? This is a followup bug for 16759 and is intended to be pushed along with it. There shouldn't actually exist column settings when the upgrade is done.
Created attachment 68488 [details] [review] Bug 19038: Remove the OPACShowBarcode syspref Followed test plan and works as expected. Functionality of patch from bug 16759 appears intact too. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 68489 [details] [review] Bug 19038: QA Followup - Hide barcode column by default (as syspref default is hide) Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Dilan, please do not edit the commit message. You removed the test plan from the first patch.
Pushed to master for 17.11, thanks to everybody involved!