C4::Reserves::GetReserveCount can easily be replaced with Koha::Patron->holds->count
Created attachment 65604 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed
Created attachment 65617 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 66696 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!
Isn't this enhancement ?
(In reply to Fridolin SOMERS from comment #5) > Isn't this enhancement ? Changed to enhancement.