Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/Branch.t line 49. Resolve: not ok 14 - AddReturn respects branch item return policy - noreturn # Failed test 'AddReturn respects branch item return policy - noreturn' # at t/db_dependent/Circulation/Branch.t line 279. # got: 'yqiKrIkX' # expected: undef Cause: There is a record in clubs. The constraint in clubs on branchcode does not include a cascaded delete. The test deletes all branches. Test 14 depends on item-level_itypes==1. When you set it to Biblio, it fails.
Created attachment 65785 [details] [review] Bug 19070: Fix Circulation/Branch.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/Branch.t line 49. Resolve: not ok 14 - AddReturn respects branch item return policy - noreturn Failed test 'AddReturn respects branch item return policy - noreturn' at t/db_dependent/Circulation/Branch.t line 279. got: 'yqiKrIkX' expected: undef Cause: There is a record in clubs. The constraint in clubs on branchcode does not include a cascaded delete. The test deletes all branches. Test 14 depends on item-level_itypes==1. When you set it to Biblio, it fails. Test plan: Run t/db_dependent/Circulation/Branch.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 65827 [details] [review] [SIGNED OFF] Bug 19070: Fix Circulation/Branch.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/Branch.t line 49. Resolve: not ok 14 - AddReturn respects branch item return policy - noreturn Failed test 'AddReturn respects branch item return policy - noreturn' at t/db_dependent/Circulation/Branch.t line 279. got: 'yqiKrIkX' expected: undef Cause: There is a record in clubs. The constraint in clubs on branchcode does not include a cascaded delete. The test deletes all branches. Test 14 depends on item-level_itypes==1. When you set it to Biblio, it fails. Test plan: Run t/db_dependent/Circulation/Branch.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Could't reproduce the problem, tests pass with and without the patch.
Created attachment 65842 [details] [review] Bug 19070: Fix Circulation/Branch.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/Branch.t line 49. Resolve: not ok 14 - AddReturn respects branch item return policy - noreturn Failed test 'AddReturn respects branch item return policy - noreturn' at t/db_dependent/Circulation/Branch.t line 279. got: 'yqiKrIkX' expected: undef Cause: There is a record in clubs. The constraint in clubs on branchcode does not include a cascaded delete. The test deletes all branches. Test 14 depends on item-level_itypes==1. When you set it to Biblio, it fails. Test plan: Run t/db_dependent/Circulation/Branch.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
Patron clubs is not in 16.11.x, so this patch doesn't apply to 16.11.x.