Affected URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=[invoiceid] /cgi-bin/koha/acqui/parcels.pl?booksellerid=[booksellerid] /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=[ordernumber]&invoiceid=[invoiceid]
Created attachment 66021 [details] [review] Bug 19114 - Stored XSS in parcels.pl Test 1. Hit the page /cgi-bin/koha/acqui/parcels.pl?booksellerid=xx xx is booksellerid 2. Add a text in the field Vendor invoice that contains java script 3. Save the page. 4. Notice js is execute 5. Apply patch and reload the js is escaped Fixed XSS for parcels.pl/parcel.pl/orderreceive.pl
Fixed pages are ok with the patch, I found some more instances in the invoices, will check if other bugs exist for that.
Created attachment 66047 [details] [review] [SIGNED OFF] Bug 19114 - Stored XSS in parcels.pl Test 1. Hit the page /cgi-bin/koha/acqui/parcels.pl?booksellerid=xx xx is booksellerid 2. Add a text in the field Vendor invoice that contains java script 3. Save the page. 4. Notice js is execute 5. Apply patch and reload the js is escaped Fixed XSS for parcels.pl/parcel.pl/orderreceive.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 66066 [details] [review] Bug 19114 - Stored XSS in parcels.pl Test 1. Hit the page /cgi-bin/koha/acqui/parcels.pl?booksellerid=xx xx is booksellerid 2. Add a text in the field Vendor invoice that contains java script 3. Save the page. 4. Notice js is execute 5. Apply patch and reload the js is escaped Fixed XSS for parcels.pl/parcel.pl/orderreceive.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, is in 17.05.03
This patch has been pushed to 16.11.x and is in 16.11.11.
Pushed to 16.05.x, for 16.05.16 release - thanks Amit :0)