When a basket with a canceled order is opened again, the order status is changed to 'new'. See also bug 19024. To test: - Create a basket - Add orders to it - Cancel one of the orders - Close the basket - Check the status of your orders using the acquisition search, they should be ordered with the exception one being canceled - Open the basket again - Verify the order still shows as canceled - Leave the basket open and verify using the acquisition search, that the status of the canceled order is now 'new'. A canceled order status should always remain as canceled until we introduce an actual feature to reactivate canceled orders. Closing and reopening the basket should have no effect on the status of canceled orders.
Created attachment 66786 [details] [review] Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools
Created attachment 66787 [details] [review] Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools
Created attachment 66908 [details] [review] Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 66909 [details] [review] Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
*** Bug 17172 has been marked as a duplicate of this bug. ***
Created attachment 67436 [details] [review] Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 67437 [details] [review] Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
These patches have been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release